Skip to content

Cypress Integ test for dynamic multi-tenancy features#609

Merged
ashwin-pc merged 1 commit into
opensearch-project:mainfrom
abhivka7:Dynamic_MultiTenancy
Apr 13, 2023
Merged

Cypress Integ test for dynamic multi-tenancy features#609
ashwin-pc merged 1 commit into
opensearch-project:mainfrom
abhivka7:Dynamic_MultiTenancy

Conversation

@abhivka7
Copy link
Copy Markdown
Contributor

@abhivka7 abhivka7 commented Apr 10, 2023 •
edited
Loading

Description

Adding cypress tests for dynamic tenancy feature (opensearch-project/security-dashboards-plugin#1394)

Issues Resolved

Writing cypress tests for: opensearch-project/security-dashboards-plugin#1394

Check List

  • [✅ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Video recording for multi_tenancy Test:
https://user-images.githubusercontent.com/99718513/231845323-d896c479-26b3-460d-9f01-2462d92d668b.mp4

Video recording for default_tenant Test:

default_tenant.js.mp4

ashwin-pc
ashwin-pc reviewed Apr 11, 2023
View reviewed changes
Comment thread cypress/integration/plugins/security-dashboards-plugin/multi_tenancy.js
Copy link
Copy Markdown
Member

@ashwin-pc ashwin-pc Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this tests have so many wait statements??

Here is an example test that achieves something similar without wait statements: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/basic.spec.js

also refer to to this guide on how to write effective functional tests: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/docs/writing_tests.md

Copy link
Copy Markdown
Contributor Author

@abhivka7 abhivka7 Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashwin. I have updated my PR after following your suggestions.

@abhivka7 abhivka7 force-pushed the Dynamic_MultiTenancy branch 3 times, most recently from b0c4f10 to 2f3d2d5 Compare April 13, 2023 17:22
@abhivka7
Copy link
Copy Markdown
Contributor Author

abhivka7 commented Apr 13, 2023 •
edited
Loading

Team I have run the tests against my PR for Dashboards Security Plugin (https://github.com/opensearch-project/security-dashboards-plugin/pull/1394/files).
Here are the tests results(Ubuntu): https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/4690001741/jobs/8312499846

Can you guys please review and merge this PR?
Thanks.

ashwin-pc
ashwin-pc reviewed Apr 13, 2023
View reviewed changes
Comment thread cypress/utils/index.d.ts
header: string,
): Chainable<S>;


Copy link
Copy Markdown
Member

@ashwin-pc ashwin-pc Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment header here is wrong

Copy link
Copy Markdown
Contributor Author

@abhivka7 abhivka7 Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks @ashwin-pc for pointing this out.

Adding cypres tests for dynamic multi-tenancy features
d2dbd28 
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
@abhivka7 abhivka7 force-pushed the Dynamic_MultiTenancy branch from 2f3d2d5 to d2dbd28 Compare April 13, 2023 17:42
@ashwin-pc ashwin-pc merged commit 7ec51ed into opensearch-project:main Apr 13, 2023
@abhivka7
Copy link
Copy Markdown
Contributor Author

abhivka7 commented Apr 13, 2023

Thanks @ashwin-pc and @CCongWang for reviewing this PR.

@abhivka7 abhivka7 mentioned this pull request May 5, 2023
Merged
opensearch-trigger-bot Bot pushed a commit that referenced this pull request May 8, 2023
@abhivka7 @github-actions
Adding cypres tests for dynamic multi-tenancy features (#609)
58f2014 
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
(cherry picked from commit 7ec51ed)
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request May 8, 2023
Merged
@opensearch-trigger-bot opensearch-trigger-bot Bot mentioned this pull request May 8, 2023
Merged
opensearch-trigger-bot Bot pushed a commit that referenced this pull request May 8, 2023
@abhivka7 @github-actions
Adding cypres tests for dynamic multi-tenancy features (#609)
f5223c1 
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
(cherry picked from commit 7ec51ed)
kavilla pushed a commit that referenced this pull request May 8, 2023
@opensearch-trigger-bot @abhivka7
Adding cypres tests for dynamic multi-tenancy features (#609) (#659)
21e7a49 
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
(cherry picked from commit 7ec51ed)

Co-authored-by: Abhi Kalra <99718513+abhivka7@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request May 8, 2023
@opensearch-trigger-bot @abhivka7
Adding cypres tests for dynamic multi-tenancy features (#609) (#660)
bdbff9e 
Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
(cherry picked from commit 7ec51ed)

Co-authored-by: Abhi Kalra <99718513+abhivka7@users.noreply.github.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @abhivka7 @leanneeliatra
Adding cypres tests for dynamic multi-tenancy features (opensearch-pr…
75873c6 
…oject#609) (opensearch-project#659)

Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
(cherry picked from commit 7ec51ed)

Co-authored-by: Abhi Kalra <99718513+abhivka7@users.noreply.github.com>
Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
@Hailong-am Hailong-am mentioned this pull request Mar 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@CCongWang CCongWang CCongWang approved these changes

@tianleh tianleh Awaiting requested review from tianleh

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

Assignees

No one assigned

Labels

backport 2.x backport 2.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhivka7 @ashwin-pc @CCongWang @kavilla